Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Bug in jsxgettext causes extraction error #1306

Closed
zaach opened this issue Jun 24, 2014 · 2 comments · Fixed by #1322
Closed

Bug in jsxgettext causes extraction error #1306

zaach opened this issue Jun 24, 2014 · 2 comments · Fixed by #1322

Comments

@zaach
Copy link
Contributor

zaach commented Jun 24, 2014

The handlebars parser used by jsxgettext doesn't handle deeply nested blocks too well. We introduced another nest in 12b1fe7 which broke string extraction.

We need to patch jsxgettext.
This was referenced Jun 25, 2014
Merged
Merged
@pdehaan
Copy link
Contributor

pdehaan commented Jun 26, 2014

@zaach Is this fixed?

@zaach
Copy link
Contributor Author

zaach commented Jun 26, 2014

I'll file a PR to upgrade the lib, then we can close this.

zaach added a commit that referenced this issue Jun 26, 2014
@zaach
fix(l10n): upgrade jsxgettext to handle nested handlebar clocks
229303a 
Fixes #1306.
@zaach zaach mentioned this issue Jun 26, 2014
Merged
@ckarlof ckarlof added this to the train-16 (Jun 30) milestone Jun 26, 2014
@ckarlof ckarlof added the has PR label Jun 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(l10n): upgrade jsxgettext to handle nested handlebar clocks mozilla/fxa-content-server
3 participants
@zaach @pdehaan @ckarlof