Terms and Privacy pages are empty

[vladikoff]

{"version":"0.16.1",
"commit":"a586a1891ef697dc69a71d1e74f42a5e59b8e8ad",
"l10n":"d29c280eff","tosPp":"c321fc714a"}

[jrgm]

This works

curl 'http://127.0.0.1:3030/en-US/legal/privacy' -H 'Host: 127.0.0.1:3030' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0' -H 'Accept: text/partial, */*; q=0.01' -H 'Accept-Language: en-US,en;q=0.5' -H 'Accept-Encoding: gzip, deflate' -H 'X-Requested-With: XMLHttpRequest' -H 'Referer: http://127.0.0.1:3030/legal/privacy' -H 'Connection: keep-alive'

This has no actual content:

curl 'http://127.0.0.1:3030/en-us/legal/privacy' -H 'Host: 127.0.0.1:3030' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0' -H 'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8' -H 'Accept-Language: en-US,en;q=0.5' -H 'Accept-Encoding: gzip, deflate' -H 'Connection: keep-alive'

[pdehaan]

@vladikoff Were you hitting the legal pages directly?

https://accounts.firefox.com/legal/terms (or the localed version: https://accounts.firefox.com/en-us/legal/terms) are blank for me, although this is working for me if I went to https://accounts.firefox.com/signup and then click on the ToS or PP links.

[shane-tomlinson]

I believe this is a dup. Digging in. The problem is the en-us part, we do not allow for that.

[shane-tomlinson]

The problem is the en-us part, we do not allow for that.

Huh, the route's path is route.path = /^\/(?:([a-zA-Z-\_]*)\/)?legal\/(terms|privacy)(?:\/)?$/

[shane-tomlinson]

ahhhhhhhh, en-us vs en-US?

[shane-tomlinson]

wait, @vladikoff - what OS are you working in, and if OSX, is your partition set up to use a case-sensitive file system? I receive text using en-us or en-US as the locale, but my partition is case insensitive.

[pdehaan]

FWIW, I'm testing on https://latest.dev.lcip.org/ and it works if I navigate to this page through /signup but not if I go to https://latest.dev.lcip.org/en-us/legal/terms directly (or refresh the TOS/PP pages).

[shane-tomlinson]

@pdehaan - strange, locally everything is great. I wonder if this is either a case sensitivity or an incorrect normalization problem.

[jrgm]

git bisect points to 46dedd0 as the first bad commit.

[shane-tomlinson]

@jrgm - you need to teach me how to use bisect.

[pdehaan]

@shane-tomlinson, I don't understand case sensitivity. It works if I navigate to the page but not if I refresh a page. Not sure how the case would be different in those cases to trigger an issue.

I also don't think I'm understanding the Network tab results in the FF/Chrome developer tools, since it looks like if I go to https://latest.dev.lcip.org/en-us/legal/terms directly it doesn't attempt to load the /config or client.json or the legal partials.

[jrgm]

@shane-tomlinson - happy to talk bisect at any time (except 10am London time).

[pdehaan]

Figure 1. My locale is set to French (fr), but I'm guessing it cannot find any translated French legal pages so it's falling back to our friendly en-us files (hence the URL).

But the screenshot does show that it's loading the outer "privacy" shell, our fingerprinted french.css file, a Firefox logo, and then the 6 font files (~190 KB).

[shane-tomlinson]

In the privacy.html src template, {{{ body }}} is being replaced by empty text.

[zaach]

@shane-tomlinson yep, when the accept header is text/html the template is not being filled in correctly.

[zaach]

The template variable shows the correct content, but isn't being found by the handlebars renderer.

[shane-tomlinson]

@zaach - the {{{ body }}} text isn't even present in the dist resources. Is it being stripped out during the compilation step?

from dist/en_US/privacy.html:

            <article id="legal-copy">

            </article>

Without the {{{ body }}} tag, the final rendering can't replace any text. :/

[zaach]

@shane-tomlinson aha, yeah just noticed that.

[shane-tomlinson]

@jrgm, @pdehaan, @vladikoff and @zaach all rock.

[zaach]

We need to fill in the ToS/PP content during the l10n-generate-pages grunt task. It's generated statically rather than dynamically now.

[pdehaan]

@shane-tomlinson: