Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

svg url in @font-face is incorrect #1382

Closed
ckarlof opened this issue Jul 11, 2014 · 2 comments · Fixed by #1384
Closed

svg url in @font-face is incorrect #1382

ckarlof opened this issue Jul 11, 2014 · 2 comments · Fixed by #1384
Assignees

Comments

@ckarlof
Copy link
Contributor

ckarlof commented Jul 11, 2014

Current: url('/fonts/latin/firasans-light.svg#Fira Sans') format('svg')
Should be: url('/fonts/latin/firasans-light.svg#fira_sanslight') format('svg')

Whatever comes after # needs to match the id in the font tag in:

<?xml version="1.0" standalone="no"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd" >
<svg xmlns="http://www.w3.org/2000/svg">
<metadata></metadata>
<defs>
<font id="fira_sanslight" horiz-adv-x="1157" >

Likewise for Fira Sans Regular and Clear Sans

@shane-tomlinson
Copy link

Interesting, I did not know that. I thought the search parameter could be anything. Will change.

shane-tomlinson pushed a commit that referenced this issue Jul 11, 2014
* Upgrade connect-fonts-firasans which now uses font version 3.111 to fix font rendering issues in IOS.
* Upgrade to grunt-connect-fonts fixes SVG font search parameter problem.

issue #1267
fixes #1382
@shane-tomlinson shane-tomlinson self-assigned this Jul 11, 2014
shane-tomlinson pushed a commit that referenced this issue Jul 11, 2014
* Upgrade connect-fonts-firasans which now uses font version 3.111 to fix font rendering issues in IOS.
* Upgrade to grunt-connect-fonts fixes SVG font search parameter problem.

issue #1267
fixes #1382
shane-tomlinson pushed a commit that referenced this issue Jul 14, 2014
* Upgrade connect-fonts-firasans which now uses font version 3.111 to fix font rendering issues in IOS.
* Upgrade to grunt-connect-fonts fixes SVG font search parameter problem.

issue #1267
fixes #1382
@pdehaan pdehaan added this to the train-17 (Jul 14) milestone Jul 14, 2014
@ckarlof ckarlof added the has PR label Jul 14, 2014
@pdehaan
Copy link
Contributor

pdehaan commented Jul 14, 2014

Fixed by #1384

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants