Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

grunt watch:livereload excepts with _.contains is not a function #6092

Closed
shane-tomlinson opened this issue Apr 20, 2018 · 5 comments · Fixed by #6097
Closed

grunt watch:livereload excepts with _.contains is not a function #6092

shane-tomlinson opened this issue Apr 20, 2018 · 5 comments · Fixed by #6097
Assignees
@shane-tomlinson

Comments

@shane-tomlinson
Copy link

➜ fxa-content-server git:(train-109-fix-chrome) ✗ grunt watch:livereload git:(train-109-fix-chrome↑1|✚2…
Running "watch:livereload" (watch) task
Waiting...
fxa-content-server.CRITICAL: uncaughtException TypeError: _.contains is not a function
at Gaze. (/Users/shanetomlinson/development/fxa-content-server/node_modules/grunt-contrib-watch/tasks/watch.js:138:18)
at emitTwo (events.js:106:13)
at Gaze.emit (events.js:191:7)
at Gaze.emit (/Users/shanetomlinson/development/fxa-content-server/node_modules/gaze/lib/gaze.js:129:32)
at /Users/shanetomlinson/development/fxa-content-server/node_modules/gaze/lib/gaze.js:437:16
at StatWatcher._pollers.(anonymous function) (/Users/shanetomlinson/development/fxa-content-server/node_modules/gaze/lib/gaze.js:345:7)
at emitTwo (events.js:106:13)
at StatWatcher.emit (events.js:191:7)
at StatWatcher._handle.onchange (fs.js:1509:10)
@vladikoff
Copy link
Contributor

@shama have you seen this? could be node 8

@shama
Copy link

shama commented Apr 20, 2018

Weird, I'll check on it.

@shama
Copy link

shama commented Apr 20, 2018

It looks like it was using lodash@4 where inside the watch task, it was still using lodash@3 (and _.contains was changed to _.includes.

I published a new version of grunt-contrib-watch with lodash updated. So doing another npm install should fix it.

@vladikoff
Copy link
Contributor

@shama 🚤 Yesssss

@shane-tomlinson
Copy link
Author

Thank you @shama!

shane-tomlinson pushed a commit that referenced this issue Apr 23, 2018
fix(build): Fix grunt watch:livereload by updating grunt-contrib-watch
fc2a86d 
Update to v1.0.1

fixes #6092
@shane-tomlinson shane-tomlinson mentioned this issue Apr 23, 2018
Merged
@ghost ghost assigned shane-tomlinson Apr 23, 2018
@ghost ghost added the waffle:active label Apr 23, 2018
vladikoff pushed a commit that referenced this issue Apr 23, 2018
@vladikoff
fix(build): Fix grunt watch:livereload by updating grunt-contrib-wa…
8f7ff77 
…tch (#6097) r=@vladikoff

Update to v1.0.1

fixes #6092
@ghost ghost removed the waffle:review label Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shane-tomlinson shane-tomlinson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): Fix grunt watch:livereload by updating grunt-contrib-watch mozilla/fxa-content-server
3 participants
@shama @vladikoff @shane-tomlinson