Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

about:welcome Audit integration of email first without iFrame #6267

Closed
davismtl opened this issue Jun 7, 2018 · 4 comments
Closed

about:welcome Audit integration of email first without iFrame #6267

davismtl opened this issue Jun 7, 2018 · 4 comments

Comments

@davismtl
Copy link

davismtl commented Jun 7, 2018

On about:welcome , they've rebuilt the /firstrun experience without the iframe.

From an FxA standpoint,

  • let's sign off to make sure it is well integrated with proper parameters.
  • let's confirm we have a way to track the email first form view without the iFrame

The only UX prob I detected is that it doesn't support a signed in state however I question how regularly a signed in user will get to about:welcome

For context:
https://bugzilla.mozilla.org/show_bug.cgi?id=1448918#c62

@davismtl davismtl changed the title Audit integration of email first without iFrame about:welcome Audit integration of email first without iFrame Jun 7, 2018
@vladikoff vladikoff self-assigned this Jun 18, 2018
@vladikoff
Copy link
Contributor

@ericawright here's an example of how the integration works jpetto/bedrock@af5d94a

Let us know if there are any issues, especially with origin requests

Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1471514

Ref: https://bugzilla.mozilla.org/show_bug.cgi?id=1448918#c62

Ref: #5882

@ericawright
Copy link

@vladikoff thanks, I was looking into it this morning briefly and there was an issue with the origin request. I saw @piatra assign themselves to the issue though, I'll double check to see if they will be implementing it.

@shane-tomlinson
Copy link

This is done!

@davismtl
Copy link
Author

@shane-tomlinson & @philbooth according to the bug, QA sees flow_begin_id and flow_begin_time in Firefox 63.0a1 (nightly).
https://bugzilla.mozilla.org/show_bug.cgi?id=1471514#c19

However, when I look in Amplitude, I don't see any email_first form views:
https://analytics.amplitude.com/mozilla-corp/chart/new/ntqg9o3

What am I doing wrong? Am I looking at the right params here? Is it just that there is no volume in nightly so this is normal? I tried to trigger the event myself but no luck.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants