Enable recovery key experiment for test emails #6468
Conversation
ghost
added
the
tests/functional/recovery_key.js
Outdated
| // to enable the panel have been performed. | ||
| .sleep(1000) | ||
|
|
||
| .then(testElementExists(selectors.SETTINGS.HEADER)); |
There was a problem hiding this comment.
the SETTINGS.HEADER element was already looked for on line 236, do you want to check for the panel here?
tests/functional/recovery_key.js
Outdated
|
|
||
| // Perform a slight sleep here to ensure that the checks | ||
| // to enable the panel have been performed. | ||
| .sleep(1000) |
There was a problem hiding this comment.
I feel like we would be better off extending the amount of time testElementExists waits for an element to be in the DOM than using sleep like this.
tests/functional/recovery_key.js
Outdated
|
|
||
| // Perform a slight sleep here to ensure that the checks | ||
| // to enable the panel have been performed. | ||
| .sleep(1000) |
There was a problem hiding this comment.
Same comment here about the sleep.
There was a problem hiding this comment.
replace it with a JS selector to check the height of the panel or something like that
There was a problem hiding this comment.
replace it with a JS selector to check the height of the panel or something like that
Even better
There was a problem hiding this comment.
Tried using the selector but got stale element exception. However, using the similar pattern as obscure element, I was able to get this passing 5/5 times (against circle). It was also faster because it would only sleep when it needed too.
vbudhram
force-pushed
the
enable-recovery-key-experiment
branch
from
998bd4a
to
f251272
Compare
|
@mozilla/fxa-devs Made some updates, this is ready for review! |
| @@ -208,6 +208,22 @@ const click = thenify(function (selector, readySelector) { | |||
| }) | |||
| .end(); | |||
| } | |||
|
|
|||
| // Check to see if the error is a `stale element exception` and | |||
Didn't get a chance to mention this in yesterday meeting but wanted to enable account recovery for Mozilla and Softvision emails this train.
This is targeted as a point release so we can rollback if needed.