Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Remove password strength "control" UI #6564

Closed
shane-tomlinson opened this issue Sep 18, 2018 · 0 comments · Fixed by #6682
Closed

Remove password strength "control" UI #6564

shane-tomlinson opened this issue Sep 18, 2018 · 0 comments · Fixed by #6682

Comments

@shane-tomlinson
Copy link

Follow on from #6563.

Now that we have decided designF is the winner, we should rip out the original control UI and code.

shane-tomlinson pushed a commit that referenced this issue Oct 31, 2018
DesignF is no longer considered experimental, it's the default.

Because experiments are not enabled by default in functional
tests, the functional tests aren't testing reality. The
pw-strength UI is not displayed in the functional tests unless
the magic query params `&forceExperiment=passwordStrength&passwordExperimentGroup=designF`
are added to the URL.

Note, password strength experiment metrics will no longer be
sent to Amplitude.

blocks #6572
blocks #6573
fixes #6564
fixes #6400
shane-tomlinson pushed a commit that referenced this issue Oct 31, 2018
DesignF is no longer considered experimental, it's the default.

Because experiments are not enabled by default in functional
tests, the functional tests aren't testing reality. The
pw-strength UI is not displayed in the functional tests unless
the magic query params `&forceExperiment=passwordStrength&passwordExperimentGroup=designF`
are added to the URL.

Note, password strength experiment metrics will no longer be
sent to Amplitude.

blocks #6572
blocks #6573
fixes #6564
fixes #6400
shane-tomlinson pushed a commit that referenced this issue Oct 31, 2018
DesignF is no longer considered experimental, it's the default.

Because experiments are not enabled by default in functional
tests, the functional tests aren't testing reality. The
pw-strength UI is not displayed in the functional tests unless
the magic query params `&forceExperiment=passwordStrength&passwordExperimentGroup=designF`
are added to the URL.

Note, password strength experiment metrics will no longer be
sent to Amplitude.

blocks #6572
blocks #6573
fixes #6564
fixes #6400
@ghost ghost removed the waffle:backlog label Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant