Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

sign out link displays after change password #812

Closed
edwindotcom opened this issue Mar 25, 2014 · 3 comments · Fixed by #1292
Closed

sign out link displays after change password #812

edwindotcom opened this issue Mar 25, 2014 · 3 comments · Fixed by #1292

Comments

@edwindotcom
Copy link

  1. in nightly - sign in to fxa (about:accounts)
  2. change password, submit

actual: upon successful change - 'sign out' link is displayed.

expected: 'sign out' should not be displayed since we have 'delete account'

@ckarlof
Copy link
Contributor

ckarlof commented Mar 25, 2014

against stage or prod?

@ckarlof
Copy link
Contributor

ckarlof commented Mar 25, 2014

@nchapman if it's against stage, this might be a regression created by moving to sessionStorage. Password change needs to sign in again after changing the password and I bet it's losing the session context.

Another wrinkle is that changing your password will disconnect you from the browser you're in anyway. We can probably address this better by having better integration between the "Settings" page and the browser.

@ckarlof ckarlof added this to the train-12 (Apr 28) milestone Apr 7, 2014
@ckarlof ckarlof modified the milestones: train-13 (May 19), train-12 (May 5, oauth alpha release) Apr 28, 2014
@ckarlof
Copy link
Contributor

ckarlof commented May 1, 2014

Short term fix for this is to carry over the "desktop" context when we re-create the context after changing the password.

@ckarlof ckarlof modified the milestones: train-15 (Jun 16), train-13 (May 19) May 12, 2014
@ckarlof ckarlof modified the milestones: train-16 (Jun 30), train-15 (Jun 16) Jun 3, 2014
@ckarlof ckarlof added the has PR label Jun 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants