-
Notifications
You must be signed in to change notification settings - Fork 120
Duplicate header in legal/privacy #958
Comments
Fun!
You can also see in the above screenshot that the Markdown-ization of the date isn't 100% correct. The raw markdown, /firefox_cloud_services_PrivacyNotice/de.md, says: 26. März 2014
{: datetime="2014-03-26" } But Markdown typically ignores the numbering and assumes this is a
|
FWIW, stripping the duplicate header should be an easier dilemma since we could just blindly remove the first line of the markdown, or use some regex to strip out the first from the converted markdown. I'd venture we want to try tweaking the imported legal-docs to keep the header consistency, but I'll defer to our UX wonder-twins for their blessing./summon @ryanfeeley @johngruen |
You've outdone yourself, @pdehaan. |
mozilla/legal-docs#70; PR has been submitted to fix the weird Markdown date issue where certain locales were treating the date like an ordered list due to the decimal. |
@zaach, if you're interested in the brute force markdown stripping solution, this should do the trick...Just change grunttasks/replace.js:15-18 to the following (I can also PR this if you/ryan/john want it): replacements: [
{
from: /{:\s.*?\s}/g,
to: ''
}, {
from: /^#\s.*?\n$/m,
to: ''
}
] |
Screw it, #959 submitted. Reject away if we decide to go a different direction. |
If you look closely, you'll see "Firefox Cloud Services Privacy Notice" is written twice.
I'm inclined to say we should strip the one found in the Markdown documents, but, we pay for those.
/cc @ckarlof
The text was updated successfully, but these errors were encountered: