Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Duplicate header in legal/privacy #958

Closed
zaach opened this issue Apr 19, 2014 · 6 comments · Fixed by #959
Closed

Duplicate header in legal/privacy #958

zaach opened this issue Apr 19, 2014 · 6 comments · Fixed by #959

Comments

@zaach
Copy link
Contributor

zaach commented Apr 19, 2014

If you look closely, you'll see "Firefox Cloud Services Privacy Notice" is written twice.

I'm inclined to say we should strip the one found in the Markdown documents, but, we pay for those.

/cc @ckarlof

@pdehaan
Copy link
Contributor

pdehaan commented Apr 19, 2014

Fun!
I wanna play too!

screenshot_4_18_14_6_10_pm
Figue 1: German. Note that the translations are kinda, different. One translates "Firefox Cloud Services" one doesn't. I don't speak German, but the translations seem different for "Privacy Notice" seem different.


You can also see in the above screenshot that the Markdown-ization of the date isn't 100% correct. The raw markdown, /firefox_cloud_services_PrivacyNotice/de.md, says:

26. März 2014
{: datetime="2014-03-26" }

But Markdown typically ignores the numbering and assumes this is a

    and sets the numbering (or in this case the day) to 1. Markdown isn't wrong, just a side-effect. This may be harder to fix from our side since we'd have to magically know whether something is a period terminating date string versus a
      bullet (like we see in the /legal/terms/ pages.

@pdehaan
Copy link
Contributor

pdehaan commented Apr 19, 2014

FWIW, stripping the duplicate header should be an easier dilemma since we could just blindly remove the first line of the markdown, or use some regex to strip out the first

from the converted markdown. I'd venture we want to try tweaking the imported legal-docs to keep the header consistency, but I'll defer to our UX wonder-twins for their blessing.

ux_wonder_twins

/summon @ryanfeeley @johngruen

@zaach
Copy link
Contributor Author

zaach commented Apr 19, 2014

You've outdone yourself, @pdehaan.

@pdehaan
Copy link
Contributor

pdehaan commented Apr 21, 2014

mozilla/legal-docs#70; PR has been submitted to fix the weird Markdown date issue where certain locales were treating the date like an ordered list due to the decimal.

@pdehaan
Copy link
Contributor

pdehaan commented Apr 21, 2014

@zaach, if you're interested in the brute force markdown

stripping solution, this should do the trick...

Just change grunttasks/replace.js:15-18 to the following (I can also PR this if you/ryan/john want it):

      replacements: [
        {
          from: /{:\s.*?\s}/g,
          to: ''
        }, {
          from: /^#\s.*?\n$/m,
          to: ''
        }
      ]

@pdehaan
Copy link
Contributor

pdehaan commented Apr 21, 2014

Screw it, #959 submitted. Reject away if we decide to go a different direction.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants