This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(tests): Make IE10/IE11 pass all the mocha tests. #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* IE10 passes with no additional work. * IE11 requires mouse interaction for the tests to complete correctly. issue #1334
| d.resolve(keypair); | ||
| }); | ||
| return d.promise; | ||
| return client.getRandomBytes() |
There was a problem hiding this comment.
Should we feature test here and save a network request for clients that support native crypto random?
…rypto.getRandomValues.
|
@zaach - updated to only collect entropy from the server for browsers that do not support |
|
fixes #1342 |
|
|
zaach
added a commit
that referenced
this pull request
Jul 8, 2014
fix(tests): Make IE10/IE11 pass all the mocha tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1334