This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(client): Replace the fi with fi (no ligature).
#2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM. |
shane-tomlinson
pushed a commit
that referenced
this pull request
Mar 31, 2015
fix(client): Replace the `fi` with `fi` (no ligature). Thanks for the review Peter! r=@pdehaan
|
@shane-tomlinson Now that this beauty is merged, what do we need to do in the *-l10n repo? I assume just a simple search/replace in the .PO files to remove the ligatures there too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this involves a string change, it can't be merged until after train-35 is cut.
fixes #2213