This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
feat(client): remove synchronization of unmasking on change pwd fields #3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
|
|
||
| setPasswordVisibility: function (isVisible) { | ||
| getTargets: function (button) { | ||
| var unsynchronizedInput = !! this.$(button).attr('data-unsynchronized-input'); |
There was a problem hiding this comment.
Have you tried using https://api.jquery.com/data/ here instead?
|
Tested this on reset and change password, works well! 👍 |
|
@larissagaulia make sure to rebase your commits against |
larissagaulia
force-pushed
the
i3600
branch
2 times, most recently
from
bda781b
to
5187987
Compare
|
👍 Good work, another issue fixed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3600