Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

chore(nsp): Add .nsprc config file to ignore NSP warnings #3693

Merged
merged 1 commit into from
Apr 28, 2016

Conversation

pdehaan
Copy link
Contributor

@pdehaan pdehaan commented Apr 27, 2016

This drops the nsp warnings down to 4:

Running "nsp" task
Warning: (+) 4 vulnerabilities found
 Name     Installed   Patched    Path                                                                                                  More Info
 moment   2.8.4       >=2.11.2   fxa-content-server@0.60.0 > express-able@0.4.4 > able@0.4.3 > convict@0.6.1 > moment@2.8.4            https://nodesecurity.io/advisories/55
 moment   2.9.0       >=2.11.2   fxa-content-server@0.60.0 > express-able@0.4.4 > able@0.4.3 > hapi@8.4.0 > joi@6.0.8 > moment@2.9.0   https://nodesecurity.io/advisories/55
 marked   0.3.5       None       fxa-content-server@0.60.0 > grunt-marked@0.1.3 > marked@0.3.5                                         https://nodesecurity.io/advisories/101
 marked   0.3.5       None       fxa-content-server@0.60.0 > marked@0.3.5                                                              https://nodesecurity.io/advisories/101
 Use --force to continue.

Aborted due to warnings.
  1. I'll file a bug/PR shortly to update convict to able.
  2. Once we update that, we are stuck with the moment issue buried in hapi, unless we bump the major version.
  3. That just leaves marked which never seems to have been updated. We may want to consider replacing it with a different Markdown rendering engine (and hope for 100% compatibility), or, we can just add the https://nodesecurity.io/advisories/101 exception to the .nsprc file.

@vladikoff
Copy link
Contributor

@pdehaan sorry, why are we adding the hapi one to exceptions?

@pdehaan
Copy link
Contributor Author

pdehaan commented Apr 27, 2016

@vladikoff Because it'll constantly complain/warn until we update to Hapi 11.x (which IIRC requires a major version bump to node@4), which I don't see us doing anytime soon unless we want to stop supporting Node 0.10/0.12.

I was hoping we could get the number of NSP warnings down to zero, and then remove the Grunt --force flag, so the build would fail again on new reported vulnerabilities so we'd know if something went wrong in npm-land. We'd either have to wait for a new fixed version of a module to be released, add an exception to .nsprc, or else add that --force flag back until we can do one of the two other options.

@vladikoff vladikoff merged commit d0af441 into mozilla:master Apr 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants