This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(metrics): POST metrics if *any* field has changed since the last send. #4602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-tomlinson
commented
Jan 10, 2017
| // a subset of `_lastFlushedData`, in which case no flush should occur. | ||
| return _.any(data, (value, key) => { | ||
| // these keys are distinct every flush attempt, ignore. | ||
| if (key === 'duration' || key === 'flushTime') { |
There was a problem hiding this comment.
I'm OK with ignoring both duration and flushTime when doing the comparison. _isFlushRequired used to return false if both data.events and data.timers was empty, which would occur after a flush. If either array contained an entry, data would be sent. This function still acts the same, if both events and timers are empty, no send, if either has an entry, send.
shane-tomlinson
changed the title
…send. This fixes a problem where clicks on the app store marketing buttons were not recorded if metrics were already flushed but no new events were logged. The only two fields that do *not* cause metrics to be flushed are `duration` and `flushTime` since these will be different on every send. fixes #4479
shane-tomlinson
changed the title
shane-tomlinson
force-pushed
the
issue-4479-app-store-button-clicks
branch
from
eb2fd6b
to
90b0627
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where clicks on the app store marketing buttons were not
recorded if metrics were already flushed but no new events were logged.
The only two fields that do not cause metrics to be flushed are
durationandflushTimesince these will be different on every send.fixes #4479
@vladikoff - r?