Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

fix(tests): Bail out after the first test failure to speed test runs. #4678

Merged
merged 1 commit into from Jan 27, 2017
Merged

fix(tests): Bail out after the first test failure to speed test runs. #4678

merged 1 commit into from Jan 27, 2017

Conversation

shane-tomlinson
Copy link

@shane-tomlinson shane-tomlinson commented Jan 26, 2017 •
edited

Circle and travis keep running, even after there's a test failure.

This is an experiment.

Also bump timeout to 45 seconds.

vladikoff
vladikoff reviewed Jan 26, 2017
View reviewed changes
tests/intern.js
@@ -40,7 +40,9 @@ function (intern, topic, firefoxProfile) {

var config = {
asyncTimeout: asyncTimeout,
bail: true, // bail after the first test.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shane-tomlinson can we make this an option in the cli via args?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but i think it should be fine as true for default.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladikoff - sure, I just wanted to see whether it worked. It does. :D

vladikoff
vladikoff reviewed Jan 26, 2017
View reviewed changes
tests/intern.js
capabilities: {},
defaultTimeout: 45000, // 30 seconds just isn't long enough for some tests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@vladikoff
Copy link
Contributor

@shane-tomlinson while you are in functional tests there is a thing...

I noticed a thing that may happen with the verification. In our tests we have:

'#fxa-sign-in-complete-header which 'validates' that the account was verified. However that is wrong, the header can appear but the XHR request to verify is still in progress. I had to use this here: .then(testElementExists('.account-ready-service')) 6bf3da9#diff-4187c6483e21fb190a187e522477fa19R277 I think that part only shows up once XHR is complete.

fix(tests): Bail out after the first test failure on Circle to speed …
cdd75a0 
…test runs.

Also bump timeout to 45 seconds.
@shane-tomlinson shane-tomlinson changed the title fix(tests): Bail out after the first test failure to speed test runs. fix(tests): Bail out after the first test failure on Circle to speed test runs. Jan 27, 2017
@shane-tomlinson
Copy link
Author

@vladikoff - r?

@shane-tomlinson shane-tomlinson changed the title fix(tests): Bail out after the first test failure on Circle to speed test runs. fix(tests): Bail out after the first test failure to speed test runs. Jan 27, 2017
@vladikoff vladikoff merged commit 94acc26 into master Jan 27, 2017
@rfk rfk added this to the FxA-0: quality milestone Feb 16, 2017
@shane-tomlinson shane-tomlinson deleted the bail-after-first-failure branch November 30, 2017 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vladikoff vladikoff vladikoff approved these changes

Assignees

@vladikoff vladikoff

Labels
None yet
Projects
None yet
Milestone
FxA-0: quality
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shane-tomlinson @vladikoff @rfk