This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
refactor(oauth): Remove support for migration=amo #6131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
From mozilla/addons#3839:
And their integration was closed. migration=amo isn't being used! |
`migration=amo` will not cause an error, but no special help text is displayed either. The value is dropped on the ground. fixes #6123
shane-tomlinson
force-pushed
the
issue-6123-remove-amo-migration
branch
from
78d4603
to
ceaead5
Compare
shane-tomlinson
changed the title
|
@mozilla/fxa-devs - r? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migration=amowill not cause an error, but no specialhelp text is displayed either. The value is dropped on
the ground.
fixes #6123
Before merging, we need to find out if AMO still sends this query parameter. It doesn't seem like it when doing a quick query on DataDog.