This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(authorization): Minor updates for /authorization endpoint #6252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test to see whether /authorization correctly redirects the user to /signup did not pass an email address and looked for the wrong selector. The test was fixed by specifying an email address and updating the selector. Calling /authorization w/o an `action` query parameter should default to send users to `/oauth` and allowing the content server to decide the next step based on whether a user is signed in. fixes #6250
ghost
assigned 
|
Looks ok to me, but I know nothing about the front end models, so... |
shane-tomlinson
pushed a commit
that referenced
this pull request
Jun 5, 2018
* fix(authorization): Minor updates for /authorization endpoint (#6252) r=@vladikoff The test to see whether /authorization correctly redirects the user to /signup did not pass an email address and looked for the wrong selector. The test was fixed by specifying an email address and updating the selector. Calling /authorization w/o an `action` query parameter should default to send users to `/oauth` and allowing the content server to decide the next step based on whether a user is signed in. fixes #6250 * Release v1.113.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test to see whether /authorization correctly redirects the user
to /signup did not pass an email address and looked for the wrong
selector. The test was fixed by specifying an email address and
updating the selector.
Calling /authorization w/o an
actionquery parameter shoulddefault to send users to
/oauthand allowing the contentserver to decide the next step based on whether a user is signed in.
fixes #6250
@jrgm, @vladikoff - r?