This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
fix(metrics): send events from /metrics-flow to amplitude #6517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladikoff
approved these changes
Sep 5, 2018
| @@ -4,14 +4,16 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| const amplitude = require('../amplitude'); | |||
| const flowMetrics = require('../flow-metrics'); | ||
| const logFlowEvent = require('../flow-event').logFlowEvent; | ||
| const logger = require('../logging/log')('server.get-metrics-flow'); | ||
|
|
||
| module.exports = function (config) { | ||
| const FLOW_ID_KEY = config.get('flow_id_key'); | ||
| const FLOW_EVENT_NAME = 'flow.begin'; | ||
| const FLOW_ENTER_EMAIL_EVENT_NAME = 'flow.enter-email.view'; | ||
| const ENTER_EMAIL_SCREEN_EVENT_NAME = 'screen.enter-email.view'; | ||
| const ENTER_EMAIL_FLOW_EVENT_NAME = 'flow.enter-email.view'; |
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/fxa-amplitude-send#74.
There were two problems preventing these events from showing up in Amplitude. Firstly, as pointed out by @irrationalagent, the amplitude view events are keyed off the raw
screen...content server events rather than theflow.xxx.viewevents. But also, more fundamentally, the route handler wasn't actually sending any events to Amplitude.This PR addresses both issues.
@mozilla/fxa-devs r?