Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

feat(tests): update user-agent in functional tests #6976

Closed
wants to merge 2 commits into from
Closed

Conversation

vladikoff
Copy link
Contributor

v40 is pretty old!

@ghost ghost assigned vladikoff Feb 20, 2019
@ghost ghost added the waffle:active label Feb 20, 2019
@vladikoff vladikoff requested a review from a team February 20, 2019 18:31
@vladikoff
Copy link
Contributor Author

so with this, a bunch of functional tests go crazy because fxaStatus actually starts sending a logged in account data (from the browser).

@shane-tomlinson we need to sit down and figure this one out probably...

@shane-tomlinson
Copy link

@vladikoff - you are right, this is going to wreck havoc. We could update the openPage listener to automatically listen for and respond to the fxaccounts:fxa_status event if no listener has already been defined, hopefully only a few tests would need to be updated then.

Copy link

@shane-tomlinson shane-tomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've gotta fix all those failures before merging! I think we should be able to do that by adding a default WebChannel listener that responds to fxaccounts:fxa_status. If no listener is added by the test for the message when calling openPage, add one.

@ghost ghost assigned shane-tomlinson Feb 26, 2019
@shane-tomlinson
Copy link

There is more here, while I was running the functional tests the fxaccounts:login message needs to be handled in many cases too, the browser was actually signing in!

screenshot 2019-02-26 at 13 27 17

screenshot 2019-02-26 at 13 27 19

@shane-tomlinson shane-tomlinson mentioned this pull request Feb 27, 2019
14 tasks
@vladikoff
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants