This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
refactor(types): prefer EmailAddress type to raw strings #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbooth
commented
Oct 4, 2018
| Ok(_) => assert!(false, "DbClient::get_bounces should have failed"), | ||
| Err(error) => assert_eq!(format!("{}", error), "400 Bad Request"), | ||
| } | ||
| } |
There was a problem hiding this comment.
Here we can delete the entire test case because it's not possible to construct an invalid EmailAddress instance to pass to db.get_bounces.
philbooth
commented
Oct 4, 2018
| return false; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Again, all this ugly stuff can go now because the validation is already encapsulated inside EmailAddress.
This was referenced Oct 4, 2018
shane-tomlinson
approved these changes
Oct 5, 2018
The EmailAddress type was only being used in some places, which meant some places that weren't using it had to call `validate::email_address` manually. This change spreads it throughout most of the project, so that almost everywhere gets to benefit from strong typing. The only place I decided to leave it alone was the provider layer, where some providers have their own `EmailAddress` struct. I could have aliased it at that layer too, but by that point addresses are just dumb strings anyway so it didn't seem worth it.
philbooth
force-pushed
the
pb/strongly-typed-email-addresses
branch
from
e49fce8
to
dc08356
Compare
Merging anyway, because I have a queue of PRs that are partially blocked by this one and it's not clear if anyone else is going to review it or not. If anyone does have further feedback on this PR, feel free to mention it here and I can address it separately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EmailAddress type was only being used in some places, which meant some places that weren't using it had to call
validate::email_addressmanually. This change spreads it throughout most of the project, so that almost everywhere gets to benefit from strong typing.The only place I decided to leave alone was the provider layer, where some providers have their own
EmailAddressstruct. I could have aliased it at that layer too, but by that point addresses are just dumb strings anyway so it didn't seem worth it.(this is an extraction from
pb/166-wipbecause that branch is growing too big)@mozilla/fxa-devs r?