Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Registering Service Accounts #327

Closed
seanmonstar opened this issue Aug 26, 2015 · 4 comments
Closed

Registering Service Accounts #327

seanmonstar opened this issue Aug 26, 2015 · 4 comments

Comments

@seanmonstar
Copy link
Contributor

The first part of mozilla/fxa#53, an ability to create client that can have a public/private keypair generated, with the public key saved in a configuration file. Since this requires explicit registration with out help, use of a database isn't quite needed.

As this client doesn't need most of the properties that a typical client does, create a new config value, service_clients, with the properties client_id, pubkey, scope.

@rfk
Copy link
Contributor

rfk commented Aug 27, 2015

can have a public/private keypair generated, with the public key saved in our database

We should consider using JKUs rather than generating keys and giving them to the client. This seemed to work nicely for pre-verified tokens in the auth-server [1] and it forces us to do the right thing w.r.t. secret rotation, key revocation, etc.

I also wonder if we can just list the allowed clients and their JKUs/pubkeys in a config file to start with, rather than using a dynamic table in the database. There won't be more than a handful of them, and unlike standard client_ids, there's currently no plans to allow people to self-service these credentials.

[1] https://github.com/mozilla/fxa-auth-server/blob/master/lib/preverifier.js

@seanmonstar
Copy link
Contributor Author

Oh yea, I completely forgot we talked about this and decided on a config value instead. Major brain failure.

@seanmonstar
Copy link
Contributor Author

@billmaggs Why was this moved to multi-device metrics?

@billmaggs
Copy link

trying to make it clickable. Switched back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants