Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PayPal billing information in Checkout invoice email #7101

Closed
data-sync-user opened this issue Dec 8, 2020 · 4 comments
Closed

Use PayPal billing information in Checkout invoice email #7101

data-sync-user opened this issue Dec 8, 2020 · 4 comments
Assignees

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Dec 8, 2020

This ticket covers e-mails specific to Checkout. 

--

Invoice emails currently have a strings like "Charged to Visa" and "card ending XXXX". This is the same information shown under "Billing Information" on the Subscription Management page. We should make sure the PayPal billing information is displayed instead for PayPal customers.

Per Barry:

  • There are 3 different types of e-mails right now that include the payment information if it’s there (it’d look for the last4 property on the Customer object), so we’ll have to update those ones to check if it’s Stripe or PayPal… Similar to FXA-2801 logic.
    • First invoice e-mail
    • Subsequent invoice e-mails
    • If they cancel and then resubscribe e-mail
  • Mini-spike:
    • These e-mails are driven by Stripe webhook events. Since we're manually invoicing with Stripe, we need to make sure whenever we update the invoice, we get the right webhook events. If we mark an invoice as paid, do we get the event that would trigger the payment succeeded e-mail? If not, we need to figure that out.

[~bchen@mozilla.com]: Does SubPlat own these emails? If so, how do we change them? If not, who do we need to contact?

┆Issue is synchronized with this Jira Task
┆Issue Number: FXA-2804

@data-sync-user
Copy link
Collaborator Author

➤ Barry Chen commented:

Yes, we own the emails.  They are in fxa-auth-server.  See fxa/packages/fxa-auth-server/lib/senders/email.js and the sendSubscription*Email functions in fxa/packages/fxa-auth-server/lib/routes/subscriptions.ts

@data-sync-user
Copy link
Collaborator Author

➤ Barry Chen commented:

https://github.com/mozilla/fxa/#running-with-maildev ( https://github.com/mozilla/fxa/#running-with-maildev ) is very helpful when working with HTML emails.

@data-sync-user data-sync-user changed the title Use PayPal billing information in invoice emails Use PayPal billing information in Checkout invoice email Jan 13, 2021
@data-sync-user
Copy link
Collaborator Author

➤ Lesley Norton commented:

We've decided not to send invoice receipts to customers checking out with PayPal. PayPal sends their own version of these emails and we are concerned that sending additional emails could lead to 1.) Users thinking they have been charged twice and 2.) Users feeling like we're cluttering up their inbox with superfluous emails.

@data-sync-user
Copy link
Collaborator Author

➤ Bianca Danforth commented:

Legal says we need to keep sending these e-mails per Wil's comment in FXA-2989. Re-opening this ticket as TODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants