Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PayPal billing information in Subscription Management emails #7264

Closed
data-sync-user opened this issue Jan 13, 2021 · 2 comments · Fixed by #7653
Closed

Use PayPal billing information in Subscription Management emails #7264

data-sync-user opened this issue Jan 13, 2021 · 2 comments · Fixed by #7653
Assignees

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jan 13, 2021

This ticket covers e-mails specific to Subscription Management. 

Invoice emails currently have a strings like "Charged to Visa" and "card ending XXXX". This is the same information shown under "Billing Information" on the Subscription Management page. We should make sure the PayPal billing information is displayed instead for PayPal customers.

Per Barry:

  • There are 3 different types of e-mails right now that include the payment information if it’s there (it’d look for the last4 property on the Customer object), so we’ll have to update those ones to check if it’s Stripe or PayPal… Similar to FXA-2801 logic.
    • First invoice e-mail
    • Subsequent invoice e-mails
    • If they cancel and then resubscribe e-mail
  • Mini-spike:
    • These e-mails are driven by Stripe webhook events. Since we're manually invoicing with Stripe, we need to make sure whenever we update the invoice, we get the right webhook events. If we mark an invoice as paid, do we get the event that would trigger the payment succeeded e-mail? If not, we need to figure that out.

[~bchen@mozilla.com]: Does SubPlat own these emails? If so, how do we change them? If not, who do we need to contact?

┆Issue is synchronized with this Jira Task
┆Issue Number: FXA-2898

@data-sync-user
Copy link
Collaborator Author

➤ Lesley Norton commented:

It was decided not to send receipt emails when a user's payment method is PayPal since PayPal already issues their own version of these emails.

@data-sync-user
Copy link
Collaborator Author

➤ Bianca Danforth commented:

Per legal we do actually want to send these Subscription Management invoice e-mails; see FXA-2989.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants