Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sessionToken auth strategy from subscription management APIs #887

Closed
2 tasks
lmorchard opened this issue Apr 18, 2019 · 2 comments
Closed
2 tasks
Milestone

Comments

@lmorchard
Copy link
Contributor

lmorchard commented Apr 18, 2019

Related to #706

@lmorchard
Copy link
Contributor Author

lmorchard commented Apr 18, 2019

A couple notes here:

Can we put all of these routes under the /oauth/subscriptions path, remove the sessionToken portion of all of these and only support oauthToken? Is there a use case that requires a sessionToken to be passed? My long term personal preference is to use sessionTokens for authentication related stuff and OAuth creds for all other interactions.

And then:

Still trying to work through this one. My Hapi-knowledge is not strong, and I'm getting errors when I remove the sessionToken strategy: Payload authentication requires at least one strategy with payload support in /v1/oauth/subscriptions/plans. I'm also having trouble finding anywhere else in the auth server that just uses the oauthToken strategy as an example.

@lmorchard
Copy link
Contributor Author

lmorchard commented Apr 19, 2019

I think I just fixed the error by adding a payload: false auth option to the routes - which I swear I tried before, but 🤷‍♂️ it works now maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant