This repository has been archived by the owner on Mar 15, 2018. It is now read-only.
Convert getProducts() to a promise (bug 1143195) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var settings = fxpay.getattr('settings'); | ||
| settings.log.warn( | ||
| msg + '. This was deprecated in ' + versionDeprecated + '. ' + | ||
| 'More info: https://github.com/mozilla/fxpay/releases'); |
There was a problem hiding this comment.
Since you got the version you might point to it in the link?
There was a problem hiding this comment.
heh, yeah I suppose that works
|
r+wc |
kumar303
force-pushed
the
promised-products
branch
from
643e621
to
6e32d2d
Compare
|
oops, forgot to update the example app. Done. |
kumar303
added a commit
that referenced
this pull request
Mar 18, 2015
Convert getProducts() to a promise (bug 1143195)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@muffinresearch r?
I found out that one of our partners is already invested in fxpay so I figured supporting the old callback interface is a good idea. It wasn't too much extra code.