Re-use a constant for static temp location (#1315)

mozilla · Jul 1, 2020 · 59e1dd9 · 59e1dd9
1 parent a5a3e85
commit 59e1dd9
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/ingestion-beam/src/test/java/com/mozilla/telemetry/integration/BigQueryIntegrationTest.java b/ingestion-beam/src/test/java/com/mozilla/telemetry/integration/BigQueryIntegrationTest.java
@@ -54,6 +54,9 @@
  */
 public class BigQueryIntegrationTest extends TestWithDeterministicJson {
 
+  private static final String STATIC_TEST_TEMP = //
+      "gs://gcp-ingestion-static-test-bucket/temp/bq-loads";
+
   private BigQuery bigquery;
   private String projectId;
   private String dataset;
@@ -112,8 +115,8 @@ public void canWriteToBigQuery() throws Exception {
 
     PipelineResult result = Sink.run(new String[] { "--inputFileFormat=json", "--inputType=file",
         "--input=" + input, "--outputType=bigquery", "--bqWriteMethod=file_loads",
-        "--tempLocation=gs://gcp-ingestion-static-test-bucket/temp/bq-loads",
-        "--schemasLocation=schemas.tar.gz", "--output=" + output, "--errorOutputType=stderr" });
+        "--tempLocation=" + STATIC_TEST_TEMP, "--schemasLocation=schemas.tar.gz",
+        "--output=" + output, "--errorOutputType=stderr" });
 
     result.waitUntilFinish();
 
@@ -179,9 +182,8 @@ public void canWriteViaFileLoads() throws Exception {
     PipelineResult result = Sink.run(new String[] { "--inputFileFormat=json", "--inputType=file",
         "--input=" + input, "--outputType=bigquery", "--output=" + output,
         "--bqWriteMethod=file_loads", "--errorOutputType=file",
-        "--tempLocation=gs://gcp-ingestion-static-test-bucket/temp/bq-loads",
-        "--schemasLocation=schemas.tar.gz", "--errorOutputFileCompression=UNCOMPRESSED",
-        "--errorOutput=" + errorOutput });
+        "--tempLocation=" + STATIC_TEST_TEMP, "--schemasLocation=schemas.tar.gz",
+        "--errorOutputFileCompression=UNCOMPRESSED", "--errorOutput=" + errorOutput });
 
     result.waitUntilFinish();
 
@@ -217,9 +219,8 @@ private void canWriteWithMixedMethod(String streamingDocTypes) throws Exception
     PipelineResult result = Sink.run(new String[] { "--inputFileFormat=json", "--inputType=file",
         "--input=" + input, "--outputType=bigquery", "--output=" + output, "--bqWriteMethod=mixed",
         "--bqStreamingDocTypes=" + streamingDocTypes, "--errorOutputType=file",
-        "--tempLocation=gs://gcp-ingestion-static-test-bucket/temp/bq-loads",
-        "--schemasLocation=schemas.tar.gz", "--errorOutputFileCompression=UNCOMPRESSED",
-        "--errorOutput=" + errorOutput });
+        "--tempLocation=" + STATIC_TEST_TEMP, "--schemasLocation=schemas.tar.gz",
+        "--errorOutputFileCompression=UNCOMPRESSED", "--errorOutput=" + errorOutput });
 
     result.waitUntilFinish();
 
@@ -414,9 +415,9 @@ public void canLoadAndReadDecodedFormat() throws Exception {
 
     PipelineResult result = Sink.run(new String[] { "--inputFileFormat=json", "--inputType=file",
         "--input=" + input, "--outputType=bigquery", "--bqWriteMethod=file_loads",
-        "--tempLocation=gs://gcp-ingestion-static-test-bucket/temp/bq-loads",
-        "--decompressInputPayloads=false", "--outputTableRowFormat=decoded",
-        "--output=" + fullyQualifiedTableSpec, "--errorOutputType=stderr" });
+        "--tempLocation=" + STATIC_TEST_TEMP, "--decompressInputPayloads=false",
+        "--outputTableRowFormat=decoded", "--output=" + fullyQualifiedTableSpec,
+        "--errorOutputType=stderr" });
 
     result.waitUntilFinish();