Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1684980 - Ignore non-Glean user agents from firefox-desktop #1557

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Bug 1684980 - Ignore non-Glean user agents from firefox-desktop #1557

merged 2 commits into from
Feb 8, 2021

Conversation

acmiyaguchi
Copy link
Contributor

@acmiyaguchi
Copy link
Contributor Author

Do you have any clues into why the tests would suddenly start failing. I don't see a connection between the two failing tests, other than the testing attributeMap possibly missing fields.

@acmiyaguchi
Copy link
Contributor Author

I think this might have been an issue with the order of .equals. It seems to work after rebasing and slimming down the logic.

@acmiyaguchi acmiyaguchi requested review from scholtzan and removed request for jklukas February 8, 2021 23:24
scholtzan
scholtzan approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@scholtzan scholtzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acmiyaguchi acmiyaguchi merged commit 56bf105 into mozilla:master Feb 8, 2021
@acmiyaguchi acmiyaguchi deleted the glean-agent branch February 8, 2021 23:50
@whd whd mentioned this pull request Feb 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholtzan scholtzan scholtzan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acmiyaguchi @scholtzan