Bug 1697602 Remove AET support #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklukas
added a commit
that referenced
this pull request
Mar 12, 2021
Prerequisite for #1599 so we make sure that we drop any messages that might contain `ecosystem_anon_id` which was considered sensitive under the deployed AET design.
jklukas
added a commit
that referenced
this pull request
Mar 15, 2021
Prerequisite for #1599 so we make sure that we drop any messages that might contain `ecosystem_anon_id` which was considered sensitive under the deployed AET design.
Marking as a draft, because we'll need to think through sequencing. We can't merge this until we change ops logic to remove AET-specific jobs. We'll also need to consider what to do about the few messages still coming in from old builds of Firefox Nightly that have AET enabled.
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
============================================
- Coverage 86.33% 82.29% -4.04%
+ Complexity 759 631 -128
============================================
Files 109 78 -31
Lines 4499 3305 -1194
Branches 421 356 -65
============================================
- Hits 3884 2720 -1164
+ Misses 482 471 -11
+ Partials 133 114 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
relud
approved these changes
Mar 23, 2021
akkomar
added a commit
that referenced
this pull request
Jun 30, 2023
This will allow to ingest telemetry from server-side environments shipped to Pub/Sub via Cloud Logging. ParseLogEntry transform is used to convert LogEntries to format compatible with structured ingestion. This transform was added back in the day for AET and seems like it was intended to be removed in #1599. I'm repurposing it since it is no longer used.
akkomar
added a commit
that referenced
this pull request
Jun 30, 2023
This will allow to ingest telemetry from server-side environments shipped to Pub/Sub via Cloud Logging. ParseLogEntry transform is used to convert LogEntries to format compatible with structured ingestion. This transform was added back in the day for AET and seems like it was intended to be removed in #1599. I'm repurposing it since it is no longer used.
akkomar
added a commit
that referenced
this pull request
Jul 26, 2023
This will allow to ingest telemetry from server-side environments shipped to Pub/Sub via Cloud Logging. ParseLogEntry transform is used to convert LogEntries to format compatible with structured ingestion. This transform was added back in the day for AET and seems like it was intended to be removed in #1599. I'm repurposing it since it is no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking as a draft, because we'll need to think through sequencing.
We can't merge this until we change ops logic to remove AET-specific jobs.
We'll also need to consider what to do about the few messages still coming inHandled in #1600from old builds of Firefox Nightly that have AET enabled.