Bug 1751955 Fix edge cases for mobile search key sanitization #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://bugzilla.mozilla.org/show_bug.cgi?id=1751955#c8 This is a fixup for #1961 which was merged and deployed to stage. We need to get this change in before deploying mobile sanitization to prod.
jklukas
force-pushed
the
santize-search-codes-mobile
branch
from
4a1b68b
to
da26cbb
Compare
sean-rose
requested changes
Jan 27, 2022
ingestion-beam/src/main/java/com/mozilla/telemetry/decoder/MessageScrubber.java
Outdated
Show resolved
Hide resolved
ingestion-beam/src/main/java/com/mozilla/telemetry/decoder/MessageScrubber.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1962 +/- ##
============================================
+ Coverage 86.35% 86.37% +0.01%
- Complexity 812 814 +2
============================================
Files 117 117
Lines 4846 4853 +7
Branches 461 477 +16
============================================
+ Hits 4185 4192 +7
Misses 529 529
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sean-rose
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1751955#c8
This is a fixup for #1961 which was merged and deployed to stage.
We need to get this change in before deploying mobile sanitization to prod.