Bug 1338696: Don't deref null when nr_stun_message_create2 fails. r=drno

MozReview-Commit-ID: 6yo1NtElboR --HG-- extra : rebase_source : ea9ea0868e6d806db07ec0f3509f3588bd433395
mozilla · Feb 13, 2017 · 05f117a · 05f117a
1 parent bcf0706
commit 05f117a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/media/mtransport/third_party/nICEr/src/stun/stun_server_ctx.c b/media/mtransport/third_party/nICEr/src/stun/stun_server_ctx.c
@@ -339,10 +339,10 @@ int nr_stun_server_process_request(nr_stun_server_ctx *ctx, nr_socket *sock, cha
 
     _status=0;
   abort:
-    if (NR_STUN_GET_TYPE_CLASS(req->header.type) == NR_CLASS_INDICATION)
+    if (!res)
         goto skip_response;
 
-    if (!res)
+    if (NR_STUN_GET_TYPE_CLASS(req->header.type) == NR_CLASS_INDICATION)
         goto skip_response;
 
     /* Now respond */