Skip to content

Commit

Permalink
Bug 1617250 [wpt PR 21921] - WPT: Fix incorrect use of assert_object_…
Browse files Browse the repository at this point in the history
…equals, a=testonly

Automatic update from web-platform-tests
WPT: Fix incorrect use of assert_object_equals

This test was using assert_object_equals() to verify object identity,
similar to web-platform-tests/wpt#20844
which (a) wasn't validating identity and (2) failing in all browsers
because that assert function is subtle/weird. Switch to just
assert_equals() and remove expectation file.

General issue: web-platform-tests/wpt#2033

Change-Id: I9ee44d251b53955bb9101810142aac8e89a8b5be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068248
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743639}

--

wpt-commits: 06000cecb5cf248e8edc9e73ccb71b0ce8f09c44
wpt-pr: 21921
  • Loading branch information
inexorabletash authored and moz-wptsync-bot committed Feb 24, 2020
1 parent bbbd30c commit 6c5316e
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -12,7 +12,7 @@
var ctx = canvas.getContext('bitmaprenderer');
assert_true(ctx instanceof ImageBitmapRenderingContext);
assert_true("canvas" in ctx);
assert_object_equals(canvas, ctx.canvas);
assert_equals(canvas, ctx.canvas);
}, "Test that canvas.getContext('bitmaprenderer') returns an instance of ImageBitmapRenderingContext and ctx.canvas on a ImageBitmapRenderingContext returns the original OffscreenCanvas");

</script>

0 comments on commit 6c5316e

Please sign in to comment.