Skip to content

Commit

Permalink
Bug 1704003 - Remove expired Telemetry probe idb.failure.fileinfo_err…
Browse files Browse the repository at this point in the history
…or r=dom-storage-reviewers,jstutte

Differential Revision: https://phabricator.services.mozilla.com/D148380
  • Loading branch information
MichaelKohler committed Jun 21, 2022
1 parent 52832a2 commit de91a0e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 24 deletions.
9 changes: 1 addition & 8 deletions dom/indexedDB/ActorsParentCommon.cpp
Expand Up @@ -116,14 +116,7 @@ Result<StructuredCloneFileParent, nsresult> DeserializeStructuredCloneFile(
// XXX In bug 1432133, for some reasons DatabaseFileInfo object cannot be
// got. This is just a short-term fix, and we are working on finding the real
// cause in bug 1519859.
if (!fileInfo) {
IDB_WARNING(
"Corrupt structured clone data detected in IndexedDB. Failing the "
"database request. Bug 1519859 will address this problem.");
Telemetry::ScalarAdd(Telemetry::ScalarID::IDB_FAILURE_FILEINFO_ERROR, 1);

return Err(NS_ERROR_DOM_INDEXEDDB_UNKNOWN_ERR);
}
QM_TRY(OkIf((bool)fileInfo), Err(NS_ERROR_DOM_INDEXEDDB_UNKNOWN_ERR));

return StructuredCloneFileParent{type, std::move(fileInfo)};
}
Expand Down
16 changes: 0 additions & 16 deletions toolkit/components/telemetry/Scalars.yaml
Expand Up @@ -4175,22 +4175,6 @@ screenshots:

# The following section is for tracking the number of failure for indexedDB.
idb.failure:
fileinfo_error:
bug_numbers:
- 1432133
description: >
Tracking the number of failure due to missing fileInfo while doing
structured clone.
expires: "70"
kind: uint
notification_emails:
- ttung@mozilla.com
release_channel_collection: opt-out
products:
- 'firefox'
- 'fennec'
record_in_processes:
- 'main'
unknown_objectstore_empty_database:
bug_numbers:
- 1669730
Expand Down

0 comments on commit de91a0e

Please sign in to comment.