Skip to content

Commit

Permalink
Bug 1695565 - Fix appearance-cssom-001.html. r=boris
Browse files Browse the repository at this point in the history
* Remove some legacy appearance aliases that other engines don't
   implement.

 * Allow to pass with unimplemented <compat-auto> values, since per the
   spec the idea of these is to get them removed, see
   w3c/csswg-drafts#8506 for the ones we don't
   implement.

 * Also allow the `-moz-` prefix to be implemented, because we can't
   quite get rid of it (people use it to remove the <input type=number>
   buttons with -moz-appearance: textfield and so on), and the
   alternative is to implement a bunch of non-standard ::-webkit-
   pseudo-elements.

Differential Revision: https://phabricator.services.mozilla.com/D171243
  • Loading branch information
emilio committed Mar 1, 2023
1 parent a5b8d26 commit f93fd7b
Show file tree
Hide file tree
Showing 5 changed files with 210 additions and 242 deletions.
9 changes: 0 additions & 9 deletions devtools/shared/css/generated/properties-db.js
Original file line number Diff line number Diff line change
Expand Up @@ -253,12 +253,10 @@ exports.CSS_PROPERTIES = {
"menuradio",
"menuseparator",
"meter",
"meterbar",
"meterchunk",
"none",
"number-input",
"progress-bar",
"progressbar",
"progresschunk",
"radio",
"radio-container",
Expand Down Expand Up @@ -297,7 +295,6 @@ exports.CSS_PROPERTIES = {
"tabpanels",
"textarea",
"textfield",
"textfield-multiline",
"toolbar",
"toolbarbutton",
"toolbarbutton-dropdown",
Expand Down Expand Up @@ -1508,12 +1505,10 @@ exports.CSS_PROPERTIES = {
"menuradio",
"menuseparator",
"meter",
"meterbar",
"meterchunk",
"none",
"number-input",
"progress-bar",
"progressbar",
"progresschunk",
"radio",
"radio-container",
Expand Down Expand Up @@ -1552,7 +1547,6 @@ exports.CSS_PROPERTIES = {
"tabpanels",
"textarea",
"textfield",
"textfield-multiline",
"toolbar",
"toolbarbutton",
"toolbarbutton-dropdown",
Expand Down Expand Up @@ -3518,12 +3512,10 @@ exports.CSS_PROPERTIES = {
"menuradio",
"menuseparator",
"meter",
"meterbar",
"meterchunk",
"none",
"number-input",
"progress-bar",
"progressbar",
"progresschunk",
"radio",
"radio-container",
Expand Down Expand Up @@ -3562,7 +3554,6 @@ exports.CSS_PROPERTIES = {
"tabpanels",
"textarea",
"textfield",
"textfield-multiline",
"toolbar",
"toolbarbutton",
"toolbarbutton-dropdown",
Expand Down
2 changes: 1 addition & 1 deletion layout/reftests/forms/textbox/setsize-ref.xhtml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" xmlns:html="http://www.w3.org/1999/xhtml">

<hbox style="appearance: auto; -moz-default-appearance: textfield-multiline; width: 200px; height: 200px;"/>
<hbox style="appearance: auto; -moz-default-appearance: textarea; width: 200px; height: 200px;"/>
<html:div style="position:fixed;top:0;left:0;width:100%;height:100%;"></html:div>

</window>
3 changes: 0 additions & 3 deletions servo/components/style/values/specified/box.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1726,7 +1726,6 @@ pub enum Appearance {
/// A searchfield.
Searchfield,
/// A multi-line text field, e.g. HTML <textarea>.
#[parse(aliases = "textfield-multiline")]
Textarea,
/// A checkbox element.
Checkbox,
Expand All @@ -1737,10 +1736,8 @@ pub enum Appearance {
/// List boxes.
Listbox,
/// A horizontal meter bar.
#[parse(aliases = "meterbar")]
Meter,
/// A horizontal progress bar.
#[parse(aliases = "progressbar")]
ProgressBar,
/// A typical dialog button.
Button,
Expand Down
40 changes: 0 additions & 40 deletions testing/web-platform/meta/css/css-ui/appearance-cssom-001.html.ini

This file was deleted.

0 comments on commit f93fd7b

Please sign in to comment.