Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an optional base-url to cope with tests expecting wd/hub #1114

Closed
ylavoie opened this issue Dec 29, 2017 · 2 comments
Closed

Allow an optional base-url to cope with tests expecting wd/hub #1114

ylavoie opened this issue Dec 29, 2017 · 2 comments

Comments

@ylavoie
Copy link

ylavoie commented Dec 29, 2017

System

  • Version: 0.19.1
  • Platform: Unbuntu Zesty
  • Firefox: 57.0.3
  • Selenium:

Testcase

Many tests and tools were developped to connect to host:port/wd/hub. The wd/hub was stripped from geckodriver, requiring modifications to the tests instead of providing a drop in replacement.
Please consider adding a --url-base=wd/hub switch when launching the server.

@andreastt
Copy link
Contributor

We decided against adding a --url-base flag in #343. Since you already have hard-coded URL paths in your test and you would need to make changes to your client to have it work with geckodriver, it seems like less work just to make that change.

@lock
Copy link

lock bot commented Aug 17, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have run into an issue you think is related, please open a new issue.

@lock lock bot locked and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants