-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog "Plugin Container for Firefox has stopped working" displayed on DeleteSession #225
Comments
Does this happen consistently? I have noticed frequent crashes on Linux when using officially branded builds, which leads me to suspect they are set up differently. However, I’m not sure yet if this is the cause. |
@andreastt, it happens when Firefox has the child process named I can also manually reproduce the same issue by just killing |
Thank you for the excellent explanation! I don’t know why plugin-container.exe spawns when loading about:home, but I suspect what happens here is that we try to forcibly quit Firefox in geckodriver or that we interrupt the subprocess. Either way we trigger crash detection which causes the dialogue you included a screenshot of on Windows, or a the Firefox crash dialogue on Windows that I’ve seen recently. The fact that you pinpointed that this only seems to happen when on about:home was a very useful clue, because the immediate issue will get resolved by c49e5cd (coming in 0.11.0). However, to solve the underlying issue I feel we should experiment with not using |
I could be mistaken about why I see the officially branded Firefox crash on my Linux system. The crash report it generates indicates there is something wrong with X syncing: Without MOZ_X_SYNC:
With MOZ_X_SYNC:
I think this is unrelated to this issue as it also happens on starting Firefox, not on calling Edit: I’ve filed bug 1302500 about the things mentioned in this comment. It is not related to this GitHub issue. |
I just filed and patched bug 1302503 to allow GeckoDriver#quitApplication to take no parameters. |
@andreastt, I tried to send the command import socket
s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
s.connect(('127.0.0.1', 11174))
s.send(b'48:[0,1,"quitApplication",{"flags":["eForceQuit"]}]')
s.recv(1024)
s.close() So the issue is probably not with marionette but with the gecko driver itself. |
My solution (Java source): DesiredCapabilities desiredCapabilities = ...;
FirefoxProfile profile = new FirefoxProfile();
profile.setPreference("browser.startup.homepage","about:blank");
desiredCapabilities.setCapability(FirefoxDriver.PROFILE, profile);
WebDriver webDriver = new FirefoxDriver(desiredCapabilities);` |
Even though I have set the startup page to "about:blank", the plugin Container Error is still present for me. So I don't think this solution works for everybody. |
@avivasp The homepage the browser starts on was corrected, as I said earlier in this thread, in c49e5cd which will be available in the next release of geckodriver. Your fix only works incidentally because the default homepage in official branded Firefox builds causes the plugin container to be started for some reason. We are no closer to a real fix to this problem. The next thing worth investigating is if the rust-mozrunner library is signalling the browser process in a way that causes the plugin container to error. |
I tried a run on a Windows 10 vm, and surprisingly the error didnt occur anymore. |
@andreastt, I managed to avoid the crash message by setting these environement variables:
I also defined these preferences to avoid the initial page which starts the plugin container: user_pref("browser.startup.page", 0);
user_pref("browser.startup.homepage", "about:blank");
user_pref("browser.startup.homepage_override.mstone", "ignore");
user_pref("browser.usedOnWindows10", true); |
Now "firefox.exe" crashes when using quit() with Firefox 50. Log output: |
I encounter this issue as well, but only on Windows 7 |
Encountering @gerixx 's issue on Windows Server 2012 R2, Firefox 50. Also seeing OP's issue in Firefox 49 on the same OS. |
I was getting this on both Win7 and Win10, using Gecko driver 0.14.0. For those of you struggling with this, but who do not require flash, disabling the flash plug-in worked for me: profile.setPreference("plugin.state.flash", 0); I am still getting the "Firefox has stopped working" message on Win7, but Win10 is totally cleared up now. |
I don't have Win10 to test, but can confirm that disabling Flash in Firefox 52 running on Win7 doesn't help. |
I have taken @travisneedham’s advice and submitted #590 to disable Flash by default when using geckodriver. This only addresses the apparent fallout of the cc @mjzffr |
The latter issue, I should point is, is covered by #285. |
I can confirm that I no longer see the error with the latest Firefox Nightly on Windows 7. Thanks @andreastt! |
In the interests of avoiding the Aborting on channel error.: file c:/builds/moz2_slave/m-rel-w32-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2056 error we have seen frequently reported on geckodriver, this change forces the Flash plugin to be disabled by default. The Firefox homepage triggers the plugin container to start, which is causing problems when quitting Firefox through geckodriver. Since Flash cannot be interacted with through WebDriver and it is soon going away from the web, I don't think this is a big sacrifice. Fixes: #225
In the interests of avoiding the Aborting on channel error.: file c:/builds/moz2_slave/m-rel-w32-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2056 error we have seen frequently reported on geckodriver, this change forces the Flash plugin to be disabled by default. The Firefox homepage triggers the plugin container to start, which is causing problems when quitting Firefox through geckodriver. Since Flash cannot be interacted with through WebDriver and it is soon going away from the web, I don't think this is a big sacrifice. Fixes: mozilla/geckodriver#225 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 6ec30ca4a37ca04b0bfab6faa87fbdb926710a8d committer: GitHub <noreply@github.com> --HG-- extra : rebase_source : e104ed9d48d03a3e33da0226f3472eb3ee307e16
In the interests of avoiding the Aborting on channel error.: file c:/builds/moz2_slave/m-rel-w32-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2056 error we have seen frequently reported on geckodriver, this change forces the Flash plugin to be disabled by default. The Firefox homepage triggers the plugin container to start, which is causing problems when quitting Firefox through geckodriver. Since Flash cannot be interacted with through WebDriver and it is soon going away from the web, I don't think this is a big sacrifice. Fixes: mozilla/geckodriver#225 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 6ec30ca4a37ca04b0bfab6faa87fbdb926710a8d committer: GitHub <noreply@github.com>
In the interests of avoiding the Aborting on channel error.: file c:/builds/moz2_slave/m-rel-w32-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2056 error we have seen frequently reported on geckodriver, this change forces the Flash plugin to be disabled by default. The Firefox homepage triggers the plugin container to start, which is causing problems when quitting Firefox through geckodriver. Since Flash cannot be interacted with through WebDriver and it is soon going away from the web, I don't think this is a big sacrifice. Fixes: mozilla/geckodriver#225 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 6ec30ca4a37ca04b0bfab6faa87fbdb926710a8d committer: GitHub <noreply@github.com>
This issue has been automatically locked since there has not been any recent activity after it was closed. If you have run into an issue you think is related, please open a new issue. |
In the interests of avoiding the Aborting on channel error.: file c:/builds/moz2_slave/m-rel-w32-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2056 error we have seen frequently reported on geckodriver, this change forces the Flash plugin to be disabled by default. The Firefox homepage triggers the plugin container to start, which is causing problems when quitting Firefox through geckodriver. Since Flash cannot be interacted with through WebDriver and it is soon going away from the web, I don't think this is a big sacrifice. Fixes: mozilla/geckodriver#225 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 6ec30ca4a37ca04b0bfab6faa87fbdb926710a8d committer: GitHub <noreplygithub.com> UltraBlame original commit: b0a199019bcbd8dabb67d8eb30b39770bbd05200
In the interests of avoiding the Aborting on channel error.: file c:/builds/moz2_slave/m-rel-w32-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2056 error we have seen frequently reported on geckodriver, this change forces the Flash plugin to be disabled by default. The Firefox homepage triggers the plugin container to start, which is causing problems when quitting Firefox through geckodriver. Since Flash cannot be interacted with through WebDriver and it is soon going away from the web, I don't think this is a big sacrifice. Fixes: mozilla/geckodriver#225 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 6ec30ca4a37ca04b0bfab6faa87fbdb926710a8d committer: GitHub <noreplygithub.com> UltraBlame original commit: b0a199019bcbd8dabb67d8eb30b39770bbd05200
In the interests of avoiding the Aborting on channel error.: file c:/builds/moz2_slave/m-rel-w32-00000000000000000000/build/src/ipc/glue/MessageChannel.cpp, line 2056 error we have seen frequently reported on geckodriver, this change forces the Flash plugin to be disabled by default. The Firefox homepage triggers the plugin container to start, which is causing problems when quitting Firefox through geckodriver. Since Flash cannot be interacted with through WebDriver and it is soon going away from the web, I don't think this is a big sacrifice. Fixes: mozilla/geckodriver#225 Source-Repo: https://github.com/mozilla/geckodriver Source-Revision: 6ec30ca4a37ca04b0bfab6faa87fbdb926710a8d committer: GitHub <noreplygithub.com> UltraBlame original commit: b0a199019bcbd8dabb67d8eb30b39770bbd05200
On Windows, the driver doesn't properly quit Firefox which leads to a crash message box:
I found out that the driver doesn't terminate the process
plugin-container.exe
underfirefox.exe
.Config:
Windows 8.1, Firefox 48.0.2, geckodriver-v0.10.0-win64, python client 3.0.0.b2
To reproduce:
Expected:
The driver should dispose all the processes under
geckodriver.exe
when the session is terminated.The text was updated successfully, but these errors were encountered: