Fix issue creating directories in firefox profiles.

[jgraham]

This change is

[JohanLorenzo]

Out of curiosity, what's the advantage of this method compared to Path.is_dir() ?

[jgraham]

Well the directory doesn't actually exist yet, so Path.is_dir() will always be false.

[JohanLorenzo]

I confirm this patch allows extracting this archive correctly. The profile is then correctly pushed to Firefox.

Before the patch, wires just failed with a cryptic error:

DEBUG:wires::marionette: Got NewSession command
DEBUG:webdriver::command: Getting firefox_profile from capabilities
DEBUG:wires::marionette: Using custom profile
INFO:mozprofile::profile: Using profile path /tmp/rust_mozprofile.TwbAvDzFI2wb
DEBUG:webdriver::server: Returning status InternalServerError
DEBUG:webdriver::server: Returning body {"error":"unknown error","message":"other os error"}
DEBUG:hyper::server::response: writing head: Http11 InternalServerError
DEBUG:hyper::server::response: headers [
Headers { Date: Fri, 03 Jun 2016 10:04:03 GMT, Content-Length: 52, Content-Type: application/json, Connection: close, }]
DEBUG:hyper::server::response: write 52 bytes
DEBUG:hyper::server: keep_alive = false for 127.0.0.1:60516
DEBUG:hyper::server: keep_alive loop ending for 127.0.0.1:60516
ERROR  { [WebDriverError: Unable to parse new session response: {"error":"unknown error","message":"other os error"}] name: 'WebDriverError' }

[jgraham]

r? @andreastt

[andreastt]

@jgraham Are the changes to Cargo.lock here related to the patch? If not, can you apply that in a separate commit?

[jgraham]

Not really related I don't think. I can break this up.

[andreastt]

Reviewed 1 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

src/marionette.rs, line 384 [r1] (raw file):

        let unzip_path = {
            let name = file.name();
            let is_dir = name.ends_with("/");

I’m a bit surprised that zip::read::ZipFile does not offer an is_dir() function or similar, but this does the trick from what I can tell.

---

Comments from Reviewable

[andreastt]

Previously, jgraham wrote…

Not really related I don't think. I can break this up.

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable