Merge pull request #486 from mozilla/low-volume-tweak

fixes the 3-datapoint grid overlap
mozilla · May 12, 2020 · c88a1a1 · c88a1a1
2 parents 4c8423f + 5ddfd38
commit c88a1a1
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/components/explore/ProbeExplorer.svelte b/src/components/explore/ProbeExplorer.svelte
@@ -232,20 +232,15 @@ $: if (hoverValue.x) {
 
     <g slot='glam-body' let:top let:bottom let:left={lp} let:right={rp} let:yScale>
       {#if showViolins}
-        {#if !justOne}
-          <line
-            x1={(lp + rp) / 2} x2={(lp + rp) / 2} y1={top} y2={bottom} stroke=var(--digital-blue-150)
-          />
-        {/if}
-        {#if hovered.datum || (data.length > 1)}
+        {#if hovered.datum && (!justOne)}
         <AdHocViolin
           start={
             ((lp + rp) / 2) - (explorerComparisonSmallMultiple.width
             - explorerComparisonSmallMultiple.left
             - explorerComparisonSmallMultiple.right) / 2 + VIOLIN_PLOT_OFFSET
           }
           direction={-1}
-          density={insufficientData ? data[0][densityMetricType] : hovered.datum[densityMetricType]}
+          density={((data.length < 3) || !hovered.datum) ? data[0][densityMetricType] : hovered.datum[densityMetricType]}
           width={
             (explorerComparisonSmallMultiple.width
           - explorerComparisonSmallMultiple.left
@@ -264,6 +259,11 @@ $: if (hoverValue.x) {
                 - explorerComparisonSmallMultiple.left
                 - explorerComparisonSmallMultiple.right) / 2 - VIOLIN_PLOT_OFFSET} />
         {/if}
+        {#if !justOne}
+        <line
+          x1={(lp + rp) / 2} x2={(lp + rp) / 2} y1={top} y2={bottom} stroke=var(--digital-blue-150)
+        />
+      {/if}
       {/if}
     </g>
   </AggregationComparisonGraph>