Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for undefined metric type #1008

Closed
robhudson opened this issue Nov 4, 2020 · 0 comments
Closed

Add validation for undefined metric type #1008

robhudson opened this issue Nov 4, 2020 · 0 comments
Projects
GLAM kanban

Comments

@robhudson
Copy link
Member

Currently if we have a metric type that isn't listed in the probeView object, the user experiences a spinner that never loads. We should, instead, provide a custom error page to the user that they can report that they found an unknown metric type, or that this metric type is currently not supported.
@robhudson robhudson added this to To do in GLAM kanban via automation Nov 4, 2020
@robhudson robhudson moved this from To do to In progress in GLAM kanban Nov 4, 2020
robhudson added a commit that referenced this issue Nov 4, 2020
@robhudson
Fix #1008 Add validation for unknown metric types
9f8375b
robhudson added a commit that referenced this issue Nov 4, 2020
@robhudson
Fix #1008 Add validation for unknown metric types
b27db69
robhudson added a commit that referenced this issue Nov 4, 2020
@robhudson
Fix #1008 Add validation for unknown metric types
1bba247
GLAM kanban automation moved this from In progress to Done Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GLAM kanban
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robhudson