Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GLAM's store instantiation to work like GUD's #687

Closed
hamilton opened this issue Jun 29, 2020 · 0 comments
Closed

Refactor GLAM's store instantiation to work like GUD's #687

hamilton opened this issue Jun 29, 2020 · 0 comments
Assignees
@openjck
Labels
frontend
Projects
Fenix MVP work stream
Milestone
Fenix workstream

Comments

@hamilton
Copy link
Contributor

hamilton commented Jun 29, 2020 •
edited
Loading

Part of the Fenix story in #569

The store in GLAM has a lot of hard-coded functionality that gets in the way of generalizing for other products. One critical issue is the store instantiation on page load.

GUD has a nice way of instantiating the store that doesn't quite hard-code as much stuff. We could easily adapt GLAM's approach to follow that approach.
@hamilton hamilton added this to the Fenix workstream milestone Jun 29, 2020
@openjck openjck mentioned this issue Jul 15, 2020
Closed
openjck added a commit that referenced this issue Jul 22, 2020
@openjck
Merge pull request #722 from openjck/issue-687-make-store-gud
229b398 
Fix #687: Refactor store initialization
@hamilton hamilton moved this from To do to Done in Fenix MVP work stream Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@openjck openjck

Labels
frontend
Projects
No open projects
Fenix MVP work stream
  
Done
Milestone
Fenix workstream
Development

No branches or pull requests
2 participants
@hamilton @openjck