Glean prep: moves data transformation to transform-data.js; utilizes config files for mappings #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamilton
changed the title
hamilton
commented
Jul 14, 2020
hamilton
commented
Jul 14, 2020
hamilton
commented
Jul 14, 2020
hamilton
commented
Jul 14, 2020
hamilton
commented
Jul 14, 2020
hamilton
commented
Jul 14, 2020
openjck
reviewed
Jul 21, 2020
openjck
reviewed
Jul 21, 2020
openjck
reviewed
Jul 21, 2020
openjck
reviewed
Jul 21, 2020
openjck
reviewed
Jul 21, 2020
openjck
reviewed
Jul 21, 2020
openjck
reviewed
Jul 21, 2020
openjck
reviewed
Jul 21, 2020
openjck
reviewed
Jul 22, 2020
openjck
reviewed
Jul 22, 2020
openjck
reviewed
Jul 22, 2020
src/utils/transform-data.js
Outdated
| })); | ||
| formatted.sort((a, b) => { | ||
| if (a.key > b.key) return -1; | ||
| if (a.key <= b.key) return 1; |
There was a problem hiding this comment.
We can use < here since we return 0 otherwise.
…s a simple pipeline function that replaces similar functionality in probe-utils
hamilton
force-pushed
the
build-date-generalization
branch
from
11c707e
to
5c93096
Compare
|
r+ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #723, closes #688, closes #287, work toward #689
completely rewrites how we're handling data; transform-data.js now has a simple pipeline function that replaces similar functionality in probe-utils.
Adds in a Fenix config file that has the dimension selector information. This won't be functional until we change the state instantiation approach + add a product selector + search.