Handle case where there is no ping or metric data (fixes #81) (#129)

mozilla · Oct 22, 2020 · 51374d7 · 51374d7
1 parent c609f4f
commit 51374d7
Showing 1 changed file with 27 additions and 19 deletions.
diff --git a/src/pages/AppDetail.svelte b/src/pages/AppDetail.svelte
@@ -62,26 +62,34 @@
       bgColor="#808895" />
   {/if}
   <h2>Pings</h2>
-  <FilterInput onChangeText={filterPings} />
-  <ul>
-    {#each filteredPings as ping}
-      <li>
-        <a href={`/apps/${params.app}/pings/${ping.name}`}>{ping.name}</a>
-        <i>{ping.description}</i>
-      </li>
-    {/each}
-  </ul>
-
+  {#if !app.pings.length}
+    <p>Currently, there are no pings available for {app.name}</p>
+  {:else}
+    <FilterInput onChangeText={filterPings} />
+    <ul>
+      {#each filteredPings as ping}
+        <li>
+          <a href={`/apps/${params.app}/pings/${ping.name}`}>{ping.name}</a>
+          <i>{ping.description}</i>
+        </li>
+      {/each}
+    </ul>
+  {/if}
   <h2>Metrics</h2>
-  <FilterInput onChangeText={filterMetrics} />
-  <ul>
-    {#each filteredMetrics as metric}
-      <li>
-        <a href={`/apps/${params.app}/metrics/${metric.name}`}>{metric.name}</a>
-        <i>{metric.description}</i>
-      </li>
-    {/each}
-  </ul>
+  {#if !app.metrics.length}
+    <p>Currently, there are no metrics available for {app.name}</p>
+  {:else}
+    <FilterInput onChangeText={filterMetrics} />
+    <ul>
+      {#each filteredMetrics as metric}
+        <li>
+          <a
+            href={`/apps/${params.app}/metrics/${metric.name}`}>{metric.name}</a>
+          <i>{metric.description}</i>
+        </li>
+      {/each}
+    </ul>
+  {/if}
 {:else}
   <NotFound pageName={params.app} itemType="application" />
 {/if}