Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing invalid links in Bugs and Data Reviews Json #102

Closed
meghajain-1711 opened this issue Oct 12, 2020 · 2 comments
Closed

Processing invalid links in Bugs and Data Reviews Json #102

meghajain-1711 opened this issue Oct 12, 2020 · 2 comments

Comments

@meghajain-1711
Copy link
Contributor

Issue description
glean.page.path bugs and data reviews hyperlinks takes to invalid Bugzilla page.

Steps to reproduce the issue :
http://localhost:5000/data/glean-js/metrics/glean.page.path.json , check the json key: value pair of bugs and data_reviews
"bugs": ["https://bugzilla.mozilla.org/show_bug.cgi?id=actually-we-dont-have-this"], "data_reviews": ["https://bugzilla.mozilla.org/show_bug.cgi?id=actually-we-dont-have-this"],

What can be done here :

  1. Check with the data source for wrong data reason and process it.
    OR
  2. Preprocess such noisy data at UI end.

Solving this issue might also require spec'ing what would the UI page say when such bugs/links are found.

@meghajain-1711
Copy link
Contributor Author

As @acmiyaguchi confirmed, this noisy data was due to glean-js being an experimental prototype app, so it didn't actually have a bug and data-review. Thanks @acmiyaguchi :)

@wlach is there some data pre-processing which we need to manage under glean dictionary proposal for similar noisy data later ? For eg: bugs and data review links which might be invalid.

@meghajain-1711 meghajain-1711 changed the title Bugs and Data Reviews Json value "ACTUALLYWEDONTHAVETHIS" Processing invalid links in Bugs and Data Reviews Json Oct 12, 2020
@wlach
Copy link
Contributor

wlach commented Jan 15, 2021

My sense is that it's probably not glean-dictionary's job to validate this kind of bad data. That should be taken care of via tools like glean-parser -- if the data we ingest has a bad link in it, hopefully people will notice and we can fix it at the source. 😄

@wlach wlach closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants