-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting a 404 on console for favicon. #154
Comments
I believe this is web browser default behaviour to just check for this, so we're not seeing this because of anything we're doing wrong. That said, we should create/add a favicon at some point for sure. |
Great, whenever that's (favicon) available, I would just go ahead and add it then. |
It's actually missing from the project (as opposed to being browser behavior). glean-dictionary/public/index.html Line 9 in df3b400
|
OPTION ONEOPTION TWOOPTION THREE@wlach What do you think here? |
The rough edges would be cleared, so each template is just to give an idea. |
@LilyLME Sorry for the late reply on this. I think ideally we would have unique branding for the Glean dictionary but I think this is definitely better than nothing. Option (2) looks good to me, it probably will look reasonable when scaled down. @Dexterp37 @mdboom does this seem like reasonable use of the glean assets to you? |
@wlach yes, Option (2) looks good to me too! FWIW:
|
Oh right, I didn't even think about looking at the early glean dictionary! Moving ahead with option (2) by just copying what's in https://glean-dictionary.netlify.app/ seems like the best option -- I believe it's stored here: https://github.com/mozilla/probe-dictionary/tree/sveltify/public . Thanks @LilyLME for exploring the solution space -- I think this issue is now open if someone wants to look at it. |
The text was updated successfully, but these errors were encountered: