Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting a 404 on console for favicon. #154

Closed
LilyLME opened this issue Oct 22, 2020 · 8 comments · Fixed by #325
Closed

Getting a 404 on console for favicon. #154

LilyLME opened this issue Oct 22, 2020 · 8 comments · Fixed by #325
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@LilyLME
Copy link
Contributor

LilyLME commented Oct 22, 2020

GEThttp://localhost:5000/favicon.png
[HTTP/1.1 404 Not Found 0ms]
@wlach wlach added the enhancement New feature or request label Oct 28, 2020
@wlach
Copy link
Contributor

wlach commented Oct 28, 2020

I believe this is web browser default behaviour to just check for this, so we're not seeing this because of anything we're doing wrong. That said, we should create/add a favicon at some point for sure.

@LilyLME
Copy link
Contributor Author

LilyLME commented Oct 28, 2020

Great, whenever that's (favicon) available, I would just go ahead and add it then.

@acmiyaguchi
Copy link
Contributor

It's actually missing from the project (as opposed to being browser behavior).

<link rel="icon" type="image/png" href="/favicon.png" />

@LilyLME
Copy link
Contributor Author

LilyLME commented Nov 15, 2020

OPTION ONE

imageedit_2_7301618571

OPTION TWO

imageedit_3_2666423012

OPTION THREE

imageedit_3_8161345328

@wlach What do you think here?

@LilyLME
Copy link
Contributor Author

LilyLME commented Nov 15, 2020

The rough edges would be cleared, so each template is just to give an idea.

@wlach
Copy link
Contributor

wlach commented Nov 21, 2020

@LilyLME Sorry for the late reply on this. I think ideally we would have unique branding for the Glean dictionary but I think this is definitely better than nothing. Option (2) looks good to me, it probably will look reasonable when scaled down. @Dexterp37 @mdboom does this seem like reasonable use of the glean assets to you?

@Dexterp37
Copy link
Contributor

@LilyLME Sorry for the late reply on this. I think ideally we would have unique branding for the Glean dictionary but I think this is definitely better than nothing. Option (2) looks good to me, it probably will look reasonable when scaled down. @Dexterp37 @mdboom does this seem like reasonable use of the glean assets to you?

@wlach yes, Option (2) looks good to me too! FWIW:

@wlach
Copy link
Contributor

wlach commented Dec 19, 2020

Oh right, I didn't even think about looking at the early glean dictionary! Moving ahead with option (2) by just copying what's in https://glean-dictionary.netlify.app/ seems like the best option -- I believe it's stored here: https://github.com/mozilla/probe-dictionary/tree/sveltify/public . Thanks @LilyLME for exploring the solution space -- I think this issue is now open if someone wants to look at it.

@wlach wlach added this to the Phase 1 - MVP milestone Jan 15, 2021
@Iinh Iinh self-assigned this Jan 15, 2021
@Iinh Iinh mentioned this issue Jan 15, 2021
3 tasks
wlach pushed a commit that referenced this issue Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants