Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong email format in mozphab app #171

Closed
Iinh opened this issue Oct 28, 2020 · 1 comment
Closed

Wrong email format in mozphab app #171

Iinh opened this issue Oct 28, 2020 · 1 comment

Comments

@Iinh
Copy link
Contributor

Iinh commented Oct 28, 2020

Right now the notification email for mozphab is not in the right format:

wrongemail

This is due to an error in the source data https://probeinfo.telemetry.mozilla.org/glean/repositories.

source

We could update our email in the static data file to fix this, however I wonder if this could be better addressed by fixing it on a higher level.

@Iinh Iinh changed the title Wrong email format in mozphap app Wrong email format in mozphab app Oct 28, 2020
@wlach
Copy link
Contributor

wlach commented Oct 28, 2020

@linh Yeah I'd say this is out of scope for the glean dictionary. The file causing problems is here:

https://github.com/mozilla/probe-scraper/blob/master/repositories.yaml

Would you care to submit a quick PR there? You can just use GitHub's "edit this file" since it's such a simple change.

Aside: I'm a little surprised that foo@bar.com@bar.com is considered a valid email address, but apparently it is:

I'd say this problem is obscure/unlikely enough that it's not worth fixing at this point.

@wlach wlach closed this as completed Oct 28, 2020
Iinh added a commit to Iinh/probe-scraper that referenced this issue Oct 28, 2020
wlach pushed a commit to mozilla/probe-scraper that referenced this issue Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants