Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement skeleton of search bar #224

Open
wlach opened this issue Nov 24, 2020 · 3 comments
Open

Implement skeleton of search bar #224

wlach opened this issue Nov 24, 2020 · 3 comments
Milestone

Comments

@wlach
Copy link
Contributor

wlach commented Nov 24, 2020

The search bar is going to be a complicated beast to get right, but we have to get started somewhere. GLAM's search bar looks pretty nice and seems like a reasonable starting point for our own implementation:

image

It is defined here:

https://github.com/mozilla/glam/tree/main/src/components/search

For populating the actual content based on user input, I have started a skeleton prototype of a metadata-extraction script using lunr.js here -- it's very incomplete and probably slightly broken, but it illustrates how one would extract search metadata from ping files.

On the client side, we would automatically load the lunr data on any page load (hopefully we can keep the size reasonable) which would include the search data + just enough metadata to populate the search bar. Typing stuff into the search bar would then activate lunr. You can see some very rough client side code which I prototyped for the schema dictionary here: wlach/schema-dictionary@97b71d1

I suspect it might be on me to produce at least the first draft on this, but putting this up here in the interests of working in the open.

@wlach wlach added this to the Phase 1 - MVP milestone Dec 16, 2020
@wlach wlach mentioned this issue Dec 16, 2020
@wlach wlach self-assigned this Dec 26, 2020
@wlach
Copy link
Contributor Author

wlach commented Dec 26, 2020

Going to work on this in the new year -- assigning to myself to make this more clear.

@wlach wlach removed their assignment Jan 11, 2021
@wlach
Copy link
Contributor Author

wlach commented Jan 11, 2021

I worked a little bit on this, and it's becoming clear that this is going to be kinda confusing given the number of applications that most of our metrics are currently duplicated across. It's also not 100% clear to me that this (rather complex) feature is actually required at this juncture. I'm going to put this in the backlog, we can always return to it later.

@wlach wlach modified the milestones: Phase 1 - MVP, Backlog Jan 11, 2021
@wlach
Copy link
Contributor Author

wlach commented Mar 29, 2021

Now that we've consolidated metrics for application variants together, this feature is a bit more tractable.

Note to self: we could also consider using something like Algolia here: https://www.algolia.com/ -- I think rolling our own is probably the right call, but we should see how it goes.

wlach added a commit that referenced this issue May 28, 2021
Not used for anything right now, it's still in version control history
if we want to do something with it in the future
(see e.g.: #224).
wlach added a commit that referenced this issue May 28, 2021
Not used for anything right now, it's still in version control history
if we want to do something with it in the future
(see e.g.: #224).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant