Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination with Next Previous buttons #88

Closed
meghajain-1711 opened this issue Oct 11, 2020 · 4 comments
Closed

Pagination with Next Previous buttons #88

meghajain-1711 opened this issue Oct 11, 2020 · 4 comments
Assignees

Comments

@meghajain-1711
Copy link
Contributor

For pages like http://localhost:5000/#!/apps/fenix , navigation becomes too difficult if the data is too much.

Apart from filtering as mentioned in another issue, we can also add Next Previous Buttons to show 1 to 100 or page limit.

This will be useful when user does not have the exact search term to filter.

@LilyLME
Copy link
Contributor

LilyLME commented Oct 13, 2020

Hello @wlach @meghajain-1711 can I work on this?

@wlach
Copy link
Contributor

wlach commented Oct 15, 2020

Hello @wlach @meghajain-1711 can I work on this?

Yup! We're trying to get applicants to do at least one frontend bug as part of their work and this is a good candidate. Thank you @meghajain-1711 for filing.

Pagination that looks something like this would be good:

image

Some inspiration for creating pagination components can be found here:

https://tailwindcomponents.com/component/pagination-example

As part of this issue, I would like to see a story added for this component, you can see an example of that here:

https://github.com/mozilla/glean-dictionary/blob/main/stories/schemaviewer.stories.js

@Iinh
Copy link
Contributor

Iinh commented Dec 18, 2020

@wlach I think we can close this issue now?

@wlach
Copy link
Contributor

wlach commented Dec 18, 2020

@wlach I think we can close this issue now?

Yup! Thank you @LilyLME and @Iinh for your work here.

@wlach wlach closed this as completed Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants