New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1867126 - automatic page load instrumentation #1835
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
reviewed
Nov 24, 2023
badboy
reviewed
Nov 24, 2023
rosahbruno
changed the title
Glean built-in page_load events
Bug 1867126 - automatic page load instrumentation
Nov 28, 2023
changelog - single instance of the pageLoad metric - always record a value, fallback to a not available string
badboy
approved these changes
Dec 1, 2023
Love this! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configure auto instrumentation for page_load events.
Built-in
page_load
events can now be recorded in 2 waysenableAutoPageLoadEvents
parameter in the Glean configuration object. Whenever this is set to true, page load events will be collected automatically wheneverinitialize
is called.@mozilla/glean/metrics
object. We now exposepageLoad
which is a function that a user can call at any time to record the same page load event that would have been collected automatically.Automatic instrumentation
Example: https://debug-ping-preview.firebaseapp.com/pings/glean-from-website/9f6996dc-a336-46eb-8c93-a1278046ae10#L10
Manually call page_load
Example: https://debug-ping-preview.firebaseapp.com/pings/glean-from-website/81fd045b-c8da-4229-8464-2860b054ece7#L10
Pull Request checklist
glean/
folder, run:npm run test
Runs all testsnpm run lint
Runs all lintersCHANGELOG.md
or an explanation of why it does not need onemozilla/glean
repository