Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1886443 - automatic click events in web sample project #1900

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

rosahbruno
Copy link
Contributor

Hooks up automatic click instrumentation on the web sample project.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from badboy March 20, 2024 13:50
@Dexterp37 Dexterp37 removed the request for review from badboy March 20, 2024 14:04
Copy link
Contributor

@abhi-agg abhi-agg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rosahbruno rosahbruno merged commit 1948bd0 into main Mar 20, 2024
5 of 6 checks passed
@rosahbruno rosahbruno deleted the 1886443-click-events-in-web-sample branch March 20, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants