Bug 1677443 - Implement initialize and core metrics #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2021 17:56
BONUS: Finish implementing initialize
brizental
force-pushed
the
1677443-initialize
branch
from
fd39adf
to
f5ee468
Compare
Dexterp37
requested changes
Jan 13, 2021
Dexterp37
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a continuation of my previous PR (#22), becuase I started implementing it accidentally on that work and then realized it was not part of that PR.
Anyways,
initializeis much leaner right now than it is in the Android implementation (I've based myself off of that one). It will simply sanitize and set the app id and initialize the core metrics. That, I think, is enough for us right now, concepts such as the dirty flag I am not even sure apply to Glean.js and other stuff related to flushing events or sending deletion request pings need to be implemented yet.This branch is on top of the branch from #22, so this PR is currently blocked until the other is merged.