-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1679375 - Creates a Store interface and implements a WeakStore #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
force-pushed
the
1679375-storage
branch
from
December 2, 2020 12:06
22cbda9
to
6788349
Compare
Build size reportMerging brizental#6 into main will:
|
brizental
changed the title
Bug 1679375 - Create a Store interface and implements a WeakStore
Bug 1679375 - Creates a Store interface and implements a WeakStore
Dec 2, 2020
Dexterp37
requested changes
Dec 2, 2020
Build size reportMerging brizental#6 into main will:
|
brizental
commented
Dec 3, 2020
Dexterp37
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a generic interface to be implemented by all our stores, which will be:
The interface follows the store design described in Glean.js: Client-side storage for web extensions. Applying the suggestion of consolidating
create
/update
into a single function and renamingread
toget
(just sounded nicer, IMO).Although the functions and their proposed functionalities are basically the same as in the proposal, the function signatures deviate from it. That was necessary, because the signatures proposed did not take into account the fact that our stores may contain multi-level objects.
This PR contains only the WeakStore implementation, the store which will not persist data throughout application runs. This implementation could also be used in the future to serve as a mock implementation on the persistent store for tests as well.
Finally, it also contains a bit of housekeeping work, namely: